search

ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

Disable P jones settings by default. #218

Closed JSKenyon closed 1 year ago

JSKenyon commented 2 years ago

Only support P jones application when four correlations are present. Fixes #215.

JSKenyon commented 2 years ago

The changes in this PR break the test suite as it presumes that P Jones is always enabled. This may take a bit of work to fix.

JSKenyon commented 1 year ago

All parallactic angle terms are now disabled by default as the average user will usually be working in the telescope frame. Parallactic angles may still be enabled in all cases for the input model, but it will now warn users when the data doesn't contain four correlations. Applying the inverse of the parallactic angle term i.e. rotating from the telescope frame into the sky frame, is now only supported for four correlation data as it may otherwise produce weird results.