ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

Unity model option #222

Closed landmanbester closed 1 year ago

landmanbester commented 1 year ago

Describe the problem that the feature should address When calibrating the secondary we often assume it is a unity point source at the phase center which translates to unity visibilities on the diagonals. It would be great if we didn't have to populate the MODEL_DATA column when this is the case. Note Quartical currently falls over if input_model.recipe is None

Describe the solution you'd like There should be a way to tell QuartiCal to treat the model as unity

Describe alternatives you've considered Populating the MODEL_DATA column with ones on the diagonal works but it is wasteful

bennahugo commented 1 year ago

I think this should be the default (good enough for phase and delays) if no model is available.

On Fri, 06 Jan 2023, 16:54 Landman Bester, @.***> wrote:

Describe the problem that the feature should address When calibrating the secondary we often assume it is a unity point source at the phase center which translates to unity visibilities on the diagonals. It would be great if we didn't have to populate the MODEL_DATA column when this is the case. Note Quartical currently falls over if input_model.recipe is None

Describe the solution you'd like There should be a way to tell QuartiCal to treat the model as unity

Describe alternatives you've considered Populating the MODEL_DATA column with ones on the diagonal works but it is wasteful

— Reply to this email directly, view it on GitHub https://github.com/ratt-ru/QuartiCal/issues/222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4RE6UXUAYYDEWW4VE46YDWRAWZHANCNFSM6AAAAAATTE6PTM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

JSKenyon commented 1 year ago

Please let me know if this functionality doesn't work as expected.