ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

Change approach for identifying missing columns. #228

Closed JSKenyon closed 1 year ago

JSKenyon commented 1 year ago

This should fix #226 as reported by @bennahugo. The problem was originally caused by relying on xds_from_storage_ms to produce a complete list of column names. This is unreliable as columns can be omitted if they have an invalid exemplar row (@bennahugo's case). This PR removes the problematic assert and replaces it with a try except which relies on the underlying daskms routines to raise sensible error messages which we can augment for readability.