ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

WIP: Facetted predict #38

Closed bennahugo closed 2 years ago

bennahugo commented 3 years ago

This is the first rough sketch of a facetted fft forward mode that handles for now only lsms

sjperkins commented 3 years ago

I'd strongly recommend the use of cachetools https://cachetools.readthedocs.io/en/stable/, particularly the cached decorator for implementing thread safe caching

sjperkins commented 3 years ago

I also think the predict.py file is getting quite large, it would be helpful to split it out into separate dft and fft modules.

JSKenyon commented 3 years ago

I also think the predict.py file is getting quite large, it would be helpful to split it out into separate dft and fft modules.

Agreed - @bennahugo had already discussed it. I want all QuartiCal functionality to remain as isolated as possible. Just makes future maintenance easier.