search

ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

Fix graph pickling #45

Closed sjperkins closed 3 years ago

sjperkins commented 3 years ago

namedtuple names in the global space need to be the same as their actual name in order to pickle.

sjperkins commented 3 years ago

This allows pickling of the graph which should in principle allow transmission of the graph to the scheduler. Haven't tried it out yet.

JSKenyon commented 3 years ago

This looks good to me and thanks @sjperkins for figuring this out! That seems like a somewhat subtle thing that would have taken me ages to figure out. Are you happy to test your branch before we merge?

sjperkins commented 3 years ago

This looks good to me and thanks @sjperkins for figuring this out! That seems like a somewhat subtle thing that would have taken me ages to figure out. Are you happy to test your branch before we merge?

Yes, let me test a bit more.

JSKenyon commented 3 years ago

I am not sure why the tests aren't triggering. Maybe because this is from a fork?

sjperkins commented 3 years ago

I can see them triggering on the PR but you may not see them because of the fork?

JSKenyon commented 3 years ago

Yeah - looks like this is a known thing with actions. Apparently, because the PR originates from your fork, it won't trigger my actions for security reasons.

sjperkins commented 3 years ago

Tests pass on my fork and the graph serializes onto the CHPC. I think this would be a good point for a review.

Could you run a local test please?

sjperkins commented 3 years ago

I'm not sure why the tests aren't triggering on the master merge, but https://github.com/JSKenyon/QuartiCal/actions/runs/377569887 passes

JSKenyon commented 3 years ago

It has something to do with forks I think. Will need to figure it out at some point.