search

ratt-ru / QuartiCal

CubiCal, but with greater power.
MIT License
8 stars 4 forks source link

Add annotations #58

Closed JSKenyon closed 3 years ago

JSKenyon commented 3 years ago

This is not yet ready for merging as it is too unstable - upstream churn is regularly breaking things. Currently, I can get things sort of working with dask==2021.02.0 and distributed==2021.02.0, but those versions don't necessarily have all the required functionality and certainly have some cluster-breaking bugs. I have also pinned numba==0.52.0 as 0.53.0 currently breaks compilation, likely due to dispatch. This is on my to-do list.

Additionally, there is ugly commented/hardcoded code in the executor that needs to be formally incorporated.

@sjperkins much of the original PR is unchanged, but you can have a look as/if/when you have a moment.

Edit: This does work with the current main branches - somehow I have ended up with a bad distributed version.

JSKenyon commented 3 years ago

3.9 tests are currently failing due to the numba version pinning. I will be working on updating the kernels next week.

JSKenyon commented 3 years ago

Closing in favour of #62.