search

ratt-ru / Stimela-classic

Containerized radio interferometry scripting framework -- NB: Classic version is no longer in active development, use stimela 2! See README for details.
GNU General Public License v2.0
28 stars 16 forks source link

incorrect parameters in parameter.json file for simulator cab and simms cab #592

Open adamdeller opened 4 years ago

adamdeller commented 4 years ago

The parameters.json file for the simulator cab seems to be busted in quite a number of places, with a few "ints" where there should be "floats" (most notably the gain parameters), and quite a few description strings seemingly mistakenly copy pasted (the gain min max parameters seemed to have the description strings for phases, or periods).

For the simms cab, the lat-lon-elv parameter is given as a list of floats in the json file, but this then ends up being passed as multiple repeated --lon-lat-elv parameters to simms. See https://github.com/ratt-ru/Stimela/issues/585#issuecomment-621120522 for more details. Changing the type of the lat-lon-elv parameter to a string makes it work, but providing a list of floats kind of reasonable so it might be better to find and correct the place where it is being misused.

SpheMakh commented 4 years ago

@Athanaseus can you please have a look at this