Closed sjperkins closed 4 years ago
@JSKenyon Could you please review?
With this PR, I now see the following behaviour https://github.com/ska-sa/dask-ms/issues/92#issuecomment-618380352
This change may have impacts on I/O but I believe its an acceptable change for now and I'd be happy to review other proposed solutions in future.
It also might be reasonable to set the cache size to 4MB in the case of getcolslice cases
Although https://github.com/casacore/casacore/issues/1018#issuecomment-618333792 would mitigate against a 4MB cache.
Going to plumb this in now. Will let you know how it goes.
I have tried this out - seems to work correctly. There is a small impact on performance but well worth the hit to prevent the memory bloat.
[x] Tests added / passed
If the pep8 tests fail, the quickest way to correct this is to run
autopep8
and thenflake8
andpycodestyle
to fix the remaining issues.[x] Fully documented, including
HISTORY.rst
for all changes and one of thedocs/*-api.rst
files for new APITo build the docs locally: