Closed JSKenyon closed 2 years ago
In general xds_{from,to}_
should be modified to take **kwargs
instead of keywords and manually pop off the keywords required for the context.
Then, at the end of the chain, warnings can be emitted for the remaining kwargs.
Description
When attempting to switch to
xds_from_storage_table
andxds_from_storage_ms
I was blocked by the fact that the kwargs are not accepted across all the backends. The errors are typically something like:What I Did
Desired behaviour
In my opinion, all the backends should support the kwargs they can and raise warnings/ignore those they cannot. It would be even better if they were all fully compatible, but I realise that that may not be possible.