Pass key word Arguments to pyrap.tables.table

ratt-ru / dask-ms

Implementation of a dask/xarray dataset backed by a CASA MS

https://dask-ms.readthedocs.io

Other

19 stars 7 forks source link

Pass key word Arguments to pyrap.tables.table #21

Closed Mulan-94 closed 5 years ago

Mulan-94 commented 5 years ago

Hi @sjperkins , I would like to prevent pyrap from giving acknowledgement messages using the ack parameter but I notice when I pass this, it has no effect. Is it useful to add to the xds_from_ms api? If I do have a patch already available that sort of works. Can I push it?

sjperkins commented 5 years ago

Hi @Mulan-94. It certainly would be useful -- I know @bennahugo wants it.

Push your changes up and I'll take a look.

sjperkins commented 5 years ago

Do create a pull request and please don't push to master.

Mulan-94 commented 5 years ago

Ok great! But I don't have permission to push :( , could you assist?

sjperkins commented 5 years ago

You don't need write access to the repo, you can create a fork and create a pull request from that https://guides.github.com/activities/forking/

sjperkins commented 5 years ago

Implemented in #24