Closed sjperkins closed 1 year ago
Closes #280
Previously, setmaxcachesize was called with a write lock, but this was problematic for readonly tables as setmaxcachesize was called during read ops.
setmaxcachesize
As setmaxcachesize only modifies the internal casacore column caching, this can safely be made a read operation.
[x] Tests added / passed
$ py.test -v -s daskms/tests
If the pep8 tests fail, the quickest way to correct this is to run autopep8 and then flake8 and pycodestyle to fix the remaining issues.
autopep8
flake8
pycodestyle
$ pip install -U autopep8 flake8 pycodestyle $ autopep8 -r -i daskms $ flake8 daskms $ pycodestyle daskms
[x] Fully documented, including HISTORY.rst for all changes and one of the docs/*-api.rst files for new API
HISTORY.rst
docs/*-api.rst
To build the docs locally:
pip install -r requirements.readthedocs.txt cd docs READTHEDOCS=True make html
@landmanbester Do you want to give this branch a try?
Thanks @sjperkins. I've kicked it off, so far so good
It ran through successfully so I think we are all good. Thanks
Closes #280
Previously,
setmaxcachesize
was called with a write lock, but this was problematic for readonly tables as setmaxcachesize was called during read ops.As
setmaxcachesize
only modifies the internal casacore column caching, this can safely be made a read operation.[x] Tests added / passed
If the pep8 tests fail, the quickest way to correct this is to run
autopep8
and thenflake8
andpycodestyle
to fix the remaining issues.[x] Fully documented, including
HISTORY.rst
for all changes and one of thedocs/*-api.rst
files for new APITo build the docs locally: