search

ratt-ru / meqtrees-cattery

MeqTrees-based frameworks for simulation and calibration of radio interferometers
Other
5 stars 9 forks source link

Updated code to remove or simulate the effects of the ionosphere on #100

Closed twillis449 closed 4 years ago

twillis449 commented 5 years ago

Finally got around to implementing your advice re github as given back in your e-mail of April 25 2019. I had to finally get going on learning about github pull requests as Benjamin Hugo wanted that done for the MeqTrees visualization stuff. :)

o-smirnov commented 5 years ago

Excellent, you'll grow to love it I'm sure!

May I suggest renaming the top-level TDL script? The name suggests the ionosphere itself is being rotated.

ratt-priv-ci commented 4 years ago

Can one of the admins verify this patch?

bennahugo commented 4 years ago

ok to test

twillis449 commented 4 years ago

One might note that this piece of code is only designed to work with 'short' baselines where ionosphere rotation measure effects should be similar for all antennas in the array. Of course, exactly what 'short' means is open to various interpretations. :)

bennahugo commented 4 years ago

Good to know. I missed this PR and am now re-initializing our build server. So will merge when it passes. Hope you are well @twillis449

bennahugo commented 4 years ago

retest this please