search

ratt-ru / meqtrees-timba

software system for implementing and solving arbitrary Measurement Equations
4 stars 5 forks source link

meqtrees-timba does not compile under gcc 6.2.0 #43

Closed adrianjhpc closed 6 years ago

adrianjhpc commented 6 years ago

There are a couple of files that cause compilation problems with gcc 6.2.0. Specifically they produce errors like this: TFSmearFactor.cc:75:24: error: call of overloaded ‘abs(double)’ is ambiguous if( abs(freq0-freq1)/midfreq < narrow_bandlimit )

This can be fixed by adding the cmath headers in to the files in question:

meqtrees-timba/MeqNodes/src/PSVTensor.cc meqtrees-timba/MeqNodes/src/TFSmearFactor.cc

adrianjhpc commented 6 years ago

If you give me commit permissions for the repo I can create a pull request for a fix for this.

gijzelaerr commented 6 years ago

hi @adrianjhpc , you don't need commit access to issue a PR. you can fork the repo (up right), commit to a branch on that repo and then issue a PR from your fork to the main repo.

o-smirnov commented 6 years ago

That said, I've given @adrianjhpc commit access anyway. We've ~seen Yves na~ been through some tough times together so I trust him.