ratt-ru / meqtrees

A library for implementing radio astronomical Measurement Equations
http://meqtrees.net
10 stars 2 forks source link

Collections Plotter needs ampl/phase/real/imag combined plots #504

Open gijzelaerr opened 10 years ago

gijzelaerr commented 10 years ago
at 2007-01-19 02:05:28 Oleg Smirnov reported:

Collections Plotter needs ampl/phase/real/imag combined plots

gijzelaerr commented 10 years ago

Original comment thread migrated from bugzilla

at 2007-01-19 02:05:28 Oleg Smirnov replied:

Some complex data has no useful info in amplitude, but does in phase. It would be good to have a right-click menu option to switch the CP between displaying ampl, phase, real and imaginary. This option should apply globally, to all tabs in the viewer.

In the future, it would be even better to show combined ampl-phase or real-imag tracks in different colors. Auto-scaling should work independently for both, so the second track would have its axis drawn on the right side of the plot.

Or perhaps an even more general option would be to allow two tracks, but let the user select what each track means: i.e., from which Vells, and which part of the complex number. In the right-click menu, it would be structured something like:

Red track -> XX -> ampl/phase/real/imag XY -> ampl/phase/real/imag YX -> ampl/phase/real/imag YY -> ampl/phase/real/imag Blue track -> None XX -> ampl/phase/real/imag ...

The XX/XY/YX/YY labels (which are more descriptive than "Vells 1", "Vells 2", etc.) can be taken from the state record in a manner similar to plot_labels.

at 2007-01-20 21:32:28 Tony Willis replied:

I have made a start on this. Try it out. At present the option only applies to the current tab. (And of course one can continue to improve the cosmetic appearance....)

at 2007-01-21 02:54:08 Oleg Smirnov replied:

Hmmm, seems to only partially work. Works fine in view_ms.py, but when I run cal343.py in the same directory (you can try it too with that MS -- update first though), run a "G phase solution" and look at the G inspector (which I feed with G Joneses), all the tracks flatline. When I lift a track out, I can see decent phases, so the data is in there!

I'm not sure what the difference is, G Jones is also just a 2x2 tensor. Its amplitude is always 1, maybe that breaks it? Or maybe that there's only one tab in the G jones inspector?

at 2007-01-21 05:31:50 Tony Willis replied:

Oops - I was calculating the right offsets before plotting, but all plots were still displaying just the amplitude. Update and try it now. Things should look better, both with view_ms.py and cal343.py.

at 2007-01-21 16:25:37 Oleg Smirnov replied:

Ah yes, now it works. Thanks.

Shall we leave the bug open for the sake of the second suggestion (combined plots)?

at 2007-02-11 03:07:01 Tony Willis replied:

Some complex data has no useful info in amplitude, but does in phase. It would be good to have a right-click menu option to switch the CP between displaying ampl, phase, real and imaginary. This option should apply globally, to all tabs in the viewer.

A switch of option now is broadcast to all tabs.

at 2009-02-11 15:07:24 Oleg Smirnov replied:

Combined plots would still be awfully nice...