Refactor minors - Githubissues

ratt-ru / pfb-imaging

Preconditioned forward/backward clean algorithm

MIT License

6 stars 5 forks source link

Refactor minors #39

Closed landmanbester closed 3 years ago

landmanbester commented 3 years ago

Introduces the following changes:

refactored code so that minor cycles use multiple image space approximations of the gradient. This reduces the required number of full gradient evaluations
unify imaging scripts into single application with choice of which minor cycle to employ
incorporate DI gains during imaging
Include average beam pattern in forward models (for both imager and spi fitter)

landmanbester commented 3 years ago

Hmmm, strange. I'm not sure what the errors mean. @sjperkins do you mind having a look when you have sec? (not urgent)

sjperkins commented 3 years ago

The packratt errors? Probably needs a:

packratt.get('...', str(path))

It would be nice if packratt dealt with this under the hood

landmanbester commented 3 years ago

Ok, let me try that. Why would it run through locally but not on CI?

landmanbester commented 3 years ago

There is something strange going on here. If I run pytest on test_residual.py by itself it passes. Run the full test suite though and it fails with

E       yaml.representer.RepresenterError: ('cannot represent an object', PosixPath('/home/landman/.cache/packratt/7b/90/e0/88aeb60187532f6bfa1a08410d022ceed71dcaeb097bd611c8'))

../../venvs/pfbenv/lib/python3.6/site-packages/yaml/representer.py:231: RepresenterError

Also, I have three tests using packratt with exactly the same syntax, two of them run through locally. Let's see what happens on CI with str(test_dir)