ratt-ru / pfb-imaging

Preconditioned forward/backward clean algorithm
MIT License
7 stars 5 forks source link

Logging + parsing +pep8 #44

Closed landmanbester closed 2 years ago

landmanbester commented 3 years ago

Just making sure tests pass on CI because this is is turning into a big one. So far:

I still need to switch out the parser. I've taken some steps to making things omegaconf compatible but I really don't like that there is no way to add argparse --help style documentation for the options (this is my main form of documentation at this stage). I've been thinking about a hack for this (inspired by https://github.com/facebookresearch/hydra/issues/633) but it looks like something more sophisticated is on the way for omegaconf https://github.com/omry/omegaconf/issues/131

landmanbester commented 2 years ago

superseded by https://github.com/ratt-ru/pfb-clean/pull/53