search

ratt-ru / pfb-imaging

Preconditioned forward/backward clean algorithm
MIT License
7 stars 5 forks source link

There is a problem with conversion between hyphen and underscore in the opts dict #92

Closed y-mhiri closed 8 months ago

y-mhiri commented 8 months ago

When the stimela options that contains hyphens are changed to underscore all the variables are not modified.

In workers/grid.py : 

          defaults = {}
          for key in schema.grid["inputs"].keys():
              defaults[key.replace("-", "_")] = schema.grid["inputs"][key]["default"]

The schema.grid["inputs"] doesn't have 'log-directory', 'output-filename' and all options stored in a .yml. They are not converted to underscore and their opts value is NoneType, leading to a ValueError.

landmanbester commented 8 months ago

Fixed in https://github.com/ratt-ru/pfb-clean/pull/91