search

ratt-ru / pyxis

Python Extensions for Interferometry Scripting
3 stars 5 forks source link

add option to tile XXX_DATA to argo.addcol() #23

Open SpheMakh opened 9 years ago

SpheMakh commented 9 years ago

As requested by @o-smirnov: The xxx_DATA columns can be "tiled" for performance reasons. I don't know if there's a way to create a tiled column from pyrap, at least there wasn't one at the time, so I wrote the addtiedmscol utility (in C++) to do this. You might want to integrate that into addcol() somehow.

o-smirnov commented 9 years ago

Come to think of it, doesn't the add column functionality belong in ms.py? On 24 Dec 2014 12:29, "Sphesihle Makhathini" notifications@github.com wrote:

As requested by @o-smirnov https://github.com/o-smirnov: The xxx_DATA columns can be "tiled" for performance reasons. I don't know if there's a way to create a tiled column from pyrap, at least there wasn't one at the time, so I wrote the addtiedmscol utility (in C++) to do this. You might want to integrate that into addcol() somehow.

— Reply to this email directly or view it on GitHub https://github.com/ska-sa/pyxis/issues/23.

SpheMakh commented 9 years ago

Yep, it does. I will move it there when I fix this issue. But maybe I should keep a mapping to the function in argo.py, else stuff that uses it will break.