search

ratt-ru / tricolour

Holds an offline, MS direct version of the SDP online flagger.
Other
8 stars 4 forks source link

Tricolour testing strategy #37

Closed sjperkins closed 5 years ago

sjperkins commented 5 years ago

At the moment we have a set of unit tests that cover a fairly large section of the functionality:

We're missing unit tests for the continuum subtraction flagger. It would be a good thing if tests for this portion of the code were added.

It would also be useful for these unit tests to be run on every commit. As this is a private repo, we can't use travis to do this. Perhaps we can use the SDP jenkins server to achieve this.

sjperkins commented 5 years ago

@bennahugo I'm not keen on submitting binary test data to the repository. git-lfs is probably fine though.

sjperkins commented 5 years ago

@bmerry Would it be appropriate for this repo to be added to the SDP jenkins testing server.

I'd llike to test on python 3.5 and 3.6.

bmerry commented 5 years ago

We could add it to Jenkins, as long as it won't take hours to run. We don't currently have any support for Python versions other than 2.7 and 3.6 though.

bennahugo commented 5 years ago

I've added a basic acceptance test. I will put the 200mb dataset somewhere safe

bennahugo commented 5 years ago

https://drive.google.com/open?id=1yxDIXUo3Xun9WXxA0x_hvX9Fmxo9Igpr

bennahugo commented 5 years ago

Please see PR #39

bennahugo commented 5 years ago

The test runs in under 5 minutes

bennahugo commented 5 years ago

Ok our brand spanking new Jenkins instance is up and running on a VM at rhodes. I will setup a test for tricolour PRs