search

ratt-ru / tricolour

Holds an offline, MS direct version of the SDP online flagger.
Other
8 stars 4 forks source link

add basic acceptance test #39

Closed bennahugo closed 5 years ago

bennahugo commented 5 years ago

With a tiny 4 antenna dataset here:

https://drive.google.com/open?id=1yxDIXUo3Xun9WXxA0x_hvX9Fmxo9Igpr

bennahugo commented 5 years ago

I'd rest much sounder knowing we are covered by a real data test

sjperkins commented 5 years ago

I think its great to have this. Would you mind if I modified it into a pytest test case? tricolour uses pytest for all the other test cases.

bennahugo commented 5 years ago

sure. but be sure to only call tricolour once in initialization. I'm not sure if pytest supports this or not

bennahugo commented 5 years ago

I've inspected the data and I'm reasonably confident master works as advertised.

sjperkins commented 5 years ago 
$ pip install -e ~/code/tricolour[testing]
$ TRICOLOUR_TEST_MS=/location/of/acceptance_data.tar.gz py.test -s -vvv -k tests/test_acceptance.py
sjperkins commented 5 years ago

@bennahugo I've configured it to skip the acceptance tests if it can't find the dataset. Do you think this is appropriate? It could easily be set to fail.

bennahugo commented 5 years ago

Cool thanks. I would say it should fail instead. This will prevent people from pushing commits to master without checking.

I will see about getting jenkins back tomorrow and friday. For this I need a dockerfile that installes and runs tests.

Could you create one?

On Wed, 03 Jul 2019, 18:29 Simon Perkins, notifications@github.com wrote:

@bennahugo https://github.com/bennahugo I've configured it to skip the acceptance tests if it can't find the dataset. Do you think this is appropriate? It could easily be set to fail.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ska-sa/tricolour/pull/39?email_source=notifications&email_token=AB4RE6UIQFCV6F3RJMEB6PTP5THU5A5CNFSM4H5EZHPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZE7U7I#issuecomment-508164733, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4RE6RRUK3GUEIJWSE74IDP5THU5ANCNFSM4H5EZHPA .

sjperkins commented 5 years ago

Yeah its easy to create a simple testing Dockerfile. Only question is where to store the acceptance test data now?

bennahugo commented 5 years ago

If we can get LFS storage for ska-sa it would be great. Otherwise I will store it on the server itself

On Thu, Jul 4, 2019 at 10:39 AM Simon Perkins notifications@github.com wrote:

Yeah its easy to create a simple testing Dockerfile. Only question is where to store the acceptance test data now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ska-sa/tricolour/pull/39?email_source=notifications&email_token=AB4RE6QWSDYNVDSOJ7BD6ZDP5WZLDA5CNFSM4H5EZHPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZGX5QQ#issuecomment-508395202, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4RE6WXLLJGDJML7NBDHSTP5WZLDANCNFSM4H5EZHPA .

--

Benjamin Hugo

PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University

Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

sjperkins commented 5 years ago

If it was stored on the web somewhere I could set the acceptance test to download it with requests.

bennahugo commented 5 years ago

Can't you do that with the drive link?

On Thu, Jul 4, 2019 at 10:47 AM Simon Perkins notifications@github.com wrote:

If it was stored on the web somewhere I could set the acceptance test to download it with requests.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ska-sa/tricolour/pull/39?email_source=notifications&email_token=AB4RE6UR6Q2W3VWIVYCFPO3P5W2IZA5CNFSM4H5EZHPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZGYSHQ#issuecomment-508397854, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4RE6WMVAYC6UPYLKUBIFTP5W2IZANCNFSM4H5EZHPA .

--

Benjamin Hugo

PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University

Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

sjperkins commented 5 years ago

Could you make the link publicly accessible? I think I had to access it with my SKA account.

bennahugo commented 5 years ago

done. try it now

On Thu, Jul 4, 2019 at 11:05 AM Simon Perkins notifications@github.com wrote:

Could you make the link publicly accessible? I think I had to access it with my SKA account.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ska-sa/tricolour/pull/39?email_source=notifications&email_token=AB4RE6T4D4ALUM7WXAB76B3P5W4PNA5CNFSM4H5EZHPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZG2FKI#issuecomment-508404393, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4RE6RAFVQ4WI74GRVTTSTP5W4PNANCNFSM4H5EZHPA .

--

Benjamin Hugo

PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University

Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town