ratt-ru / tricolour

Holds an offline, MS direct version of the SDP online flagger.
Other
8 stars 4 forks source link

Revert "Obfuscate releases" #65

Closed sjperkins closed 4 years ago

sjperkins commented 4 years ago

Reverts ska-sa/tricolour#63

bennahugo commented 4 years ago

please remember to cherry pick the fixes for numpy

sjperkins commented 4 years ago

please remember to cherry pick the fixes for numpy

I'm sorry, I have no idea what you mean by this. Could you please explain further?

ratt-priv-ci commented 4 years ago

There are changes to the driver fixing issues introduced by the october/november release of numpy.

On Mon, Jan 6, 2020 at 10:44 AM Simon Perkins notifications@github.com wrote:

please remember to cherry pick the fixes for numpy

I'm sorry, I have no idea what you mean by this. Could you please explain further?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ska-sa/tricolour/pull/65?email_source=notifications&email_token=AEIVPJWHHY5ORZXZLJPOBIDQ4LVOTA5CNFSM4KDBH7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIEZU3A#issuecomment-571054700, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIVPJUP4FZMJJAYPBMKZQLQ4LVOTANCNFSM4KDBH7LA .

--


Benjamin Hugo

Junior Software Developer SARAO Black River Park, 2 Fir Street, Observatory, Cape Town, Western Cape, 7925 Contact: [+27] 0716293858 <+27%2071%20629%203858>

PhD. student, Radio Astronomy Techniques and Technologies, Department of Physics and Electronics, Rhodes University

Skype: benna.cn

sjperkins commented 4 years ago

There are changes to the driver fixing issues introduced by the october/november release of numpy.

Which driver? Can you please point me at a link describing this? I can't see any driver in #63

sjperkins commented 4 years ago

I think it would probably be a lot simpler to just merge #64 and release 0.1.7

bennahugo commented 4 years ago

https://github.com/ska-sa/tricolour/pull/63/commits/dd87bfed945a1268b07f254955d2eda5f69c4d83

sjperkins commented 4 years ago

OK got it

sjperkins commented 4 years ago

I'll put https://github.com/ska-sa/tricolour/commit/dd87bfed945a1268b07f254955d2eda5f69c4d83 in #64