search

rauc / meta-rauc

Yocto/Open Embedded meta layer for RAUC, the embedded Linux update framework
MIT License
164 stars 91 forks source link

Fixed rauc-mark-good systemd service setup. #268

Closed esden closed 1 year ago

esden commented 1 year ago

The rauc-service package was overriding the SYSTEMD_PACKAGES variable which resulted in the rauc-mark-good systemd service not receiving it's post install scripts. Now the service should be enabled by default as intended.

esden commented 1 year ago

Hi, any chance to get this merged?

It is a very simple and obvious error in the script. Instead of overwriting SYSTEMD_PACKAGES with a =, which results in the rauc-mark-good being removed, this patch adds it using +=. In essence this patch allows both services being enabled and not just rauc-service.

I hope that prose description helps this patch along.

Here is where SYSTEMD_PACKAGES gets the rauc-mark-good added earlier in the recipe: https://github.com/rauc/meta-rauc/pull/268/files#diff-52f2ace435bad51f1e1d64674afc3a3110264e77c62660c63700d89e1f2b0d2eL13

ejoerns commented 1 year ago

@esden Thanks for pinging, just lost track.

esden commented 1 year ago

Wonderful! Thank you for merging. :)

AndreasUfert commented 1 year ago

I guess marking this as a "backport candidate" is a good sign for expecting to see this fix in branch mickledore as well, right?

ejoerns commented 1 year ago

I guess marking this as a "backport candidate" is a good sign for expecting to see this fix in branch mickledore as well, right?

I've fast-forwarded mickledore to current master now and then pinned CI to mickledore. Thus this commit is now part of mickledore. Thanks for the hint

ejoerns commented 1 year ago

cherry-picked to kirkstone