raucao / sharesome

Share files quickly from your remote storage
https://sharesome.5apps.com
23 stars 5 forks source link

Migrate to rs.js 1.0.0 #54

Closed raucao closed 6 years ago

raucao commented 7 years ago

I think this is pretty much all we need, but it would be good to implement the timeout config in rs.js before merging, because currently it has to use the default timeout, which is way too low for uploads on slow connections or with a big file size.

Edit: this needs the latest commit in the widget's noglobal branch. So be sure to delete the module from node_modules first.

raucao commented 6 years ago

Updated to latest rs.js, RS widget, and Ember.js (phew, that wasn't comfortable).

raucao commented 6 years ago

Haven't tested it yet, but the changes look pretty nice.

What's keeping you? Just npm i && npm start.

galfert commented 6 years ago

What's keeping you? Just npm i && npm start.

Nothing was keeping me. I just did the code review first.

Testing went fine as well. Couldn't find any problems.