search

raucao / webmarks

remoteStorage-enabled bookmarking app
https://webmarks.5apps.com
Other
76 stars 11 forks source link

Re-focus on search field when coming back to bookmark index page #48

Closed galfert closed 7 years ago

galfert commented 7 years ago

Closes #46

This focuses the search field when coming back to the tab (while on the bookmarks index page) using the Page Visibility API.

raucao commented 7 years ago

The existing auto-focus is happening on the component itself. Is there a reason, this can't be added to the component as well? Also, the activate one is superfluous, as it's in additon to the component's own didInsertElement one, no?

galfert commented 7 years ago

Oh, I didn't see that there is a separate component for the search input. Will move the code into there.

benrubson commented 7 years ago

Hi, Do you have some news regarding this PR ? Many thanks 👍 Ben

galfert commented 7 years ago

Oh, I kind of forgot about this one. So thanks for the reminder :)

I will try to get this ready sometime this week.

galfert commented 7 years ago

Moved the code responsible for re-focusing the field into the component itself.

Ready for review.

benrubson commented 7 years ago

Thank you very much @galfert 👍

raucao commented 7 years ago

@galfert Thanks!