search

raucao / webmarks

remoteStorage-enabled bookmarking app
https://webmarks.5apps.com
Other
76 stars 11 forks source link

Fix handling bookmarks without tags #58

Closed galfert closed 7 years ago

galfert commented 7 years ago

The recent commit 8c0f689 that was merged with PR #49 tried to fix an issues that I already fixed in master earlier, but wasn't in the PR's branch yet.

That new fix has some downsides compared to the original fix though.

  1. It still fails when there are bookmarks but those don't have any tags.
  2. When deleting the last bookmark, it would still keep the tags of that one in localStorage.

For 2. there was already a test that was now failing. For 1. I added a test in this PR.

I also added a npm install -g bower to the circle.yml as Circle was complaining about Bower not existing.

raucao commented 7 years ago

Ok, cool. Thanks.

I also added a npm install -g bower to the circle.yml as Circle was complaining about Bower not existing.

Why not add it as dev dependency then? That way nobody can run into it.

Btw, tests are red for this PR, but not sure how to approach that Sass bindings issue. I guess deleting the npm cache should be enough. Update: re-ran without cache, and it worked.