search

raucao / webmarks

remoteStorage-enabled bookmarking app
https://webmarks.5apps.com
Other
76 stars 11 forks source link

No CORS info in Apache 304 responses #67

Closed benrubson closed 5 years ago

benrubson commented 5 years ago

Hi,

I'm facing this issue where 304 Apache responses do not include CORS info : https://bz.apache.org/bugzilla/show_bug.cgi?id=51223

I use Webmarks with @fkooman PHP remoteStorage implementation.

Due to this "bug", Webmarks disconnects quickly : screen shot 2018-11-03 at 10 12 15

Is there any workaround ? Perhaps requests leading to 304 answers could be avoided / replaced by requests leading to 200 answers (but this could perhaps generate more traffic) ?

Thank you 👍

Ben

raucao commented 5 years ago

Unfortunately, there is no way to avoid this with remoteStorage. It is a protocol-level requirement. However, I thought they fixed that bug long ago.

Please open an issue with https://github.com/fkooman/php-remote-storage for resolving problems with running it. Thanks.

raucao commented 5 years ago

By the way, make sure you have followed the installation instructions, and that all required modules are enabled (e.g. headers): https://github.com/fkooman/php-remote-storage/blob/master/SERVER.md

benrubson commented 5 years ago

Thank you for your feedback @skddc. Yes, everything works as expected, but with 304 responses. Login works, bookmarks are correctly retrieved, but then, when Webmarks refreshes and gets a 304 responses, it disconnects. I clearly see it does not receive the Access-Control-Allow-Origin header anymore. I tried to force it at Apache level with the Header option, but it is removed by Apache itself for 304 responses (as per the Bugzilla above)...