Google Drive integration throws error on overview page

raucao / webmarks

remoteStorage-enabled bookmarking app

https://webmarks.5apps.com

Other

76 stars 11 forks source link

Google Drive integration throws error on overview page #84

Closed johannesjo closed 4 years ago

johannesjo commented 4 years ago

Connect via Google Drive
Add a couple of webmarks
Go back to overview
Nothing shown on the screen and the console shows Failed to load resource: the server responded with a status of 404 () for archive

Screenshot from 2020-05-13 10-59-09

raucao commented 4 years ago

Thanks for the report!

Unfortunately, I cannot reproduce this error.

Could you clarify how you would add multiple bookmarks without going back to the overview in between? The way it's described means that you were able to add the bookmarks without errors, so it would be important to know what happened then.
I don't see a storage account being connected or synced in the screenshot you posted. I don't understand why it would register a service worker when you merely navigate in a single-page app. The log looks like it's from loading the app, not from going back to the overview.

raucao commented 4 years ago

... here's what a normal startup should look like btw:

Screenshot from 2020-05-13 13-21-32

If you don't see "rs.on ready", that means the entire app wasn't loaded correctly in the first place...

johannesjo commented 4 years ago

Hmhm after logging back in the webmarks show up, but no rs.on ready or rs.on connected. The error is still there. Screenshot from 2020-05-13 14-12-31

After that I tried clearing all my storage and logging in. Which works. Then I tried deleting all entries which also works but throws Cannot delete non-existing node /.

Seems to me that the error only occurs for freshly connected "empty" accounts.

raucao commented 4 years ago

Ooh, could it be that you mixed up steps 1 and 2? That is, it fails when you add bookmarks, and then connect an empty account?

(In that case it is supposed to sync the bookmarks that were created beforehand to the newly connected account.)

johannesjo commented 4 years ago

Ooh, could it be that you mixed up steps 1 and 2? That is, it fails when you add bookmarks, and then connect an empty account?

No. I am pretty sure I connected before adding some new bookmarks.

raucao commented 4 years ago

I remembered this error from before, and it turns out we fixed that long ago. It's only a log in the console now, but doesn't impact sync anymore:

https://github.com/remotestorage/remotestorage.js/issues/993 https://github.com/remotestorage/remotestorage.js/pull/1031

raucao commented 4 years ago

Btw, what is the source that is linked for that weird 404 in your console?

raucao commented 4 years ago

Actually, if you want, we can jump on a video call for debugging this. Maybe that's more efficient, as I cannot reproduce it on my machine. (I also deleted all bookmarks earlier when I tested this.)

johannesjo commented 4 years ago

I am unable to reproduce both errors for a second time for some reason :/ Maybe it's possible to reproduce this with a fresh google account. I''ll check with removing the files and acceess for the app.

johannesjo commented 4 years ago

No luck with that neither. Maybe with a fresh account?

We can do a video call but I am not sure it makes much sense when I am unable to reproduce the issue. Don't know. Maybe I had an ancient version cached locally?

raucao commented 4 years ago

Maybe I had an ancient version cached locally?

Maybe. I switched from AppCache to ServiceWorker at some point after that fix.

As we both can't reproduce it at this point, I'll close this issue for now. Thanks anyway for opening it! And feel free to re-open anytime, of course.