rauchg / slackin

Public Slack organizations made easy
http://rauchg.com/slackin/
MIT License
6.51k stars 1.34k forks source link

Slackbot counts as a regular member, not a bot, through the Slack API #356

Open jonasrosland opened 7 years ago

jonasrosland commented 7 years ago

Hi!

When talking to Slack support regarding an inconsistency on the report of total members through the Slack API vs the desktop and mobile clients, they let me know that Slackbot is counted as a regular member through the API but not in their clients.

The users.list API method will always count Slackbot as a regular member.

Example: Slackin says you have 100 members. Clients show 99 members in #general.

So when displaying the number of total members through Slackin it is actually off by one, consistently, due to Slack counting Slackbot differently through the API vs the clients.

Is there any way of not counting Slackbot when using Slackin so we can get a consistent member total?

raxityo commented 6 years ago

It appears that the SlackBot user, other bot users, and deleted users are omitted when counting total users (or active users for that matter):

https://github.com/rauchg/slackin/blob/e9749ef9e79b61d1b7bbfc7143abde566a253675/lib/slack.js#L82-L88

(added in #26 and #57)