search

rauchg / slackin

Public Slack organizations made easy
http://rauchg.com/slackin/
MIT License
6.5k stars 1.35k forks source link

Fix deployment to IBM Cloud #384

Closed hickeyma closed 5 years ago

hickeyma commented 5 years ago

This fix updates the deployment to use a toolchain where the parameters can be configured by the user as required by slackin server during deployment.

This closes #375 and closes #186.

hickeyma commented 5 years ago

@rauchg Ready for review. Pls. note that when testing you will need to change the repository in the deployment link as follows: https://github.com/hickeyma/slackin&branch=fix-ibm-cloud-deployment. The deployment link will be shown when you click to deploy on "IBM Cloud".

The URL would then become something like this: https://console.bluemix.net/devops/setup/deploy?repository=https://github.com/hickeyma/slackin&branch=fix-ibm-cloud-deployment.

This workaround is needed because the deployment files are in my clone and branch and not yet merged into the slackin repo and master branch.

henrynash commented 5 years ago

+1 LGTM - Nice job.

hickeyma commented 5 years ago

Have received 2 +1's from @henrynash and through email from @rauchg ("Added you to the repo. I trust that you'll put it into great shape. Thank you").

@evilrabbit do you have any comments?