Fixed the failed import of MockChannel

raulcf / SEEPng

8 stars 12 forks source link

Fixed the failed import of MockChannel #62

Closed JamesDavidCarr closed 8 years ago

JamesDavidCarr commented 8 years ago

@raulcf This was causing the project to fail to compile

The only fix that's required is build.gradle but I removed trailing whitespaces and optimised imports on the failing test, which I'm happy to remove if you want.

raulcf commented 8 years ago

Looks good. A couple of comments:

Never use wildcards in import (import x.y.*), instead include all that is necessary individually.
See if you can make the commit message a bit more descriptive (it does not matter if it's longer).

Thanks,

JamesDavidCarr commented 8 years ago

I realised what the issue was so the fix is now much smaller.

And I decided not to include the code cleanup in this PR since it's actually a separate issue.

raulcf commented 8 years ago

Looks good, thanks!