search

raulcf / SEEPng

8 stars 12 forks source link

Added floating point data types support in SEEP #70

Closed elkasoapy closed 8 years ago

elkasoapy commented 8 years ago

Fixed now, thanks Panagiotis!

raulcf commented 8 years ago

How is this different from Matthias commit?

https://github.com/raulcf/SEEPng/commit/035057591f8bf71fc58b996748004f716ca02056

Is the difference that this one also supports double? If so, has it been tested with double data? It'd be great to add a unit test, there are already a bunch that can be used as example.

pgaref commented 8 years ago

The main difference is that Matthias commit introduced only the Type but ITupple should be also extended to retrieve the float/double from the api - also need support for those types in the Schema. @elkasoapy is now extending the SchemaTest to demonstate the functionality :)

raulcf commented 8 years ago

Ah! great, thanks! As soon as the test is there safe to merge

elkasoapy commented 8 years ago

Done! Please let me know if you find any other issues with this.

pgaref commented 8 years ago

Works for me :+1:

raulcf commented 8 years ago

great thanks!