search

raulcf / SEEPng

8 stars 12 forks source link

(i) Add functionalities to handle TYPE.BYTES for tuples (ii) Remove u… #87

Closed mypijika closed 8 years ago

mypijika commented 8 years ago

…cl.close() in util so that user-defined classes in the application can be successfully loaded. (iii) Add a new gradle task (called install) that is similar to mvn install

raulcf commented 8 years ago

Hi Pijika, Thanks for the PR. Did you make sure the queries (microbencharmk 1 and 2) run? Also, why do you need to close ucl in Utils? What is the effect?

Last, for style purposes, remove all commented out code if it's not necessary.

mypijika commented 8 years ago

Hi Raul,

Yes, the microbenchmark runs fine and I have tested. I am not sure about microbenchmark2 as I came across an error before the changes in the PR i.e. since commit 21d47421. Nevertheless, I think this PR is mainly for TYPE.BYTES which is neither called nor used in any microbenchmarks.

For the Utils.java, by not closing ucl, most custom classes in user applications can be properly loaded at runtime. I just commented the line ucl.close() out.

Thanks! Pijika

raulcf commented 8 years ago

great thanks!