search

raulfraile / sublime-symfony2

A Sublime Text bundle for Symfony2 development
173 stars 43 forks source link

A few enhancements to the sfcontroller snippet : namespace, parameters. #20

Closed DjebbZ closed 11 years ago

DjebbZ commented 11 years ago

I'm learning Symfony2, following the docs and the symblog tutorial along. Do you think this PR makes the snippet better ?

pylebecq commented 11 years ago

Hi, thanks for your suggestion.

As a matter of fact, I recently removed all namespaces in snippets because it is tedious to write. There are some other plugins very good at namespace handling (for example: https://github.com/erichard/SublimePHPCompanion and https://github.com/alexandresalome/sublime-alom) and it is faster to use them than writing namespace in the snippet.

I like the new parameter placeholder though. If you remove the namespace, I would be glad to merge that. Do not include "parameters" as the default value because it will force everyone to delete it if they do not want parameters.

DjebbZ commented 11 years ago

Done !

DjebbZ commented 11 years ago

Sorry for the BIG title, it's the hub command git pull-request that allow only writing of title, not body of issue. Gonna post an issue about it.

pylebecq commented 11 years ago

No worries for the big title. There is little thing you forgot: please remove the default value from the parameters placeholder. ${3:parameters} should be ${3}, like the placeholder in the render() call.

DjebbZ commented 11 years ago

Should be good to merge.

pylebecq commented 11 years ago

Thank you :+1:

DjebbZ commented 11 years ago

Does it mean it's available now in Package Control ?

pylebecq commented 11 years ago

It should be.