Closed PurpleBabar closed 9 years ago
Hey, thank you for contributing.
I don't understand why you added so many snippets related to doctrine2 annotations. We already have many of them, check this out: https://github.com/raulfraile/sublime-symfony2/tree/master/Snippets/Doctrine/Annotations .
Also, could you please update the description of the assetic related snippets ? They are all the same for now. Please try to keep the description "hierarchy" we used, like Symfony2 / Twig / Template / XXX
for stuff going to be put in twig templates.
Hi, thx for responding :)
For the vars snippets, i hesitated to override your annotations snippets giving them the var part. I acutally like the fact that the var comes with the annotations and all is made by simply typing your var name (thx to regex, the var name is normalized for mysql in the annotation). Should i override or let them in another folder ? I tried to respect your hierarchy, if somehow i failed, please tell me, and i'll gladly change it :) For the assetic snippets i didn't describes them but i putted the results (that are differents ;) ) Thx for your response ;)
For the hierarchy, you only have to fix three of your snippets:
asset
-> Symfony2 / Twig / Template / Asset function
asseticcss
-> Symfony2 / Twig / Template / Assetic CSS tag
asseticjs
-> Symfony2 / Twig / Template / Assetic JS tag
Snippets are made to reduce typing. So I think it would be a good idea to include the property generation in the snippets. The disadvantage I can see:
So if you don't mind, could you please override already provided snippets? Be sure to override all of them though, because I don't want to have two different behaviors.
No problem i'll overwrite them, should i keep the Tabtrigger to sf
Yes. Just replace the <content>
tag with your code, it will be fine. Thanks.
Did it :) Changed the README too :) hope it's ok :)
Thanks.
Minor upgrades