raulfraile / sublime-symfony2

A Sublime Text bundle for Symfony2 development
173 stars 43 forks source link

Remove sfgetset setter return type #33

Closed arturolinares closed 8 years ago

arturolinares commented 8 years ago

The setter returns the class, not the field type.

pylebecq commented 8 years ago

Hello,

Good catch. This is indeed a change we should make. But since the method actually return something, we should keep the return tag. Since @return $this is supported in PSR-5, what do you think about putting this return tag instead? I know PSR-5 has not been accepted yet, but it's already supported in

arturolinares commented 8 years ago

I wasn't aware "return $this" was supported, I'll update the snippet today.

Thanks!

arturolinares commented 8 years ago

Done. Please let me know if I missed something, I'm back to git from several years working with SVN D:

pylebecq commented 8 years ago

Can I ask you to squash your commits into one ? Then we will be good to merge. :-)

arturolinares commented 8 years ago

Squashed :)

pylebecq commented 8 years ago

Thanks