Open caseyscarborough opened 9 years ago
Also, that link shows that a fix was made, but it doesn't seem to work properly (the author couldn't replicate the issue). I've posted a comment on the pull request for that issue here.
Good thoughts @caseyscarborough. To be honest I like more the SASS syntax, but you are right, the added hassle of setting up the Ruby environment makes it very uncomfortable when setting the development environment. Anyways, is there any other reasons you want to work with LESS? We currently have 3 options for the project:
1) Migrate to LESS and get rid of SASS. Using less-asset-pipeline with less4j, I guess. 2) Start using gulpjs or grunt and watch the css files for changes. Removing the asset-pipeline and using compass and Ruby instead of JRuby. 3) Wait for the Java 8 JRuby support.
I like first and second options (I don't know if there is an ETA for the fix of JRuby). The second option would add more difficult development environment (more front-end like) but I would like in the future to add a basic structure of client-side technologies like angularjs / ember / backbone, protractor, karma, etc. to better organize the javascript code in the client (if needed).
What do you think about it?
I'm not very familiar with gulpjs or grunt, but you may be right in that it would propably add some extra complexity to setting up a development environment for the project. Personally, I think the LESS and SASS syntaxes are so similar they're almost interchangeable, but ultimately that's your call. Running it on Java 8 is not that big of a deal though, I just noticed the issue since I use that by default.
Either way, very cool project and I'm glad to contribute. Not too many folks are using Grails for their projects these days, so it's nice to see someone doing so. :+1:
Just a tip if this helps you out. You can change your line for sass-asset-pipeline
from compile
to provided
and your war wont be bundled up with jruby as its really not needed anyway. The only base dependency needed once your final project is bundled up is the main asset-pipeline
plugin. The extension modules are no longer necessary
What would you think about switching the project from SASS to LESS? I've switched my Grails projects to use LESS due to the JRuby dependency required by SASS. It causes compiled WAR files to be ~25MB larger, as well as it makes the project incompatible with Java 8. Here's a screenshot of what happens when trying to run Beerstrap on Java 8:
Just a thought. If so, I'd be more than willing to do some (or all) of the conversion.