raulhaag / MiMangaNu

*ES - Lector de Manga online / offline, gratuito y de código abierto. *EN - Manga reader online / offline, free and open source. *FR - Lecteur de manga en ligne / hors ligne, gratuit et open source. *DE - Eine App um Manga zu lesen. Man kann damit Manga online und offline lesen. Es ist kostenlos und quelloffen. *IT - Manga lettore online / offline, gratuito e open source. *RU - В России Манга читает вас. Попробуйте MiMangaNu прямо сейчас.
276 stars 74 forks source link

Seamless transition reading reset the last chapter when reaching it in horizontal reading #289

Closed ghost closed 8 years ago

ghost commented 8 years ago

When you reach the end of the last chapter in horizontal reading and with the seamless transition reading, a popup appears asking if you want to delete or not the chapter and then leave the chapter and reset it to the start marking it as unread and doesn't delete the pictures of the chapter

With the last travis

xtj-9182 commented 8 years ago

what is horizontal reading ? Is it the lock to landscape mode ?

I'm trying but I can't reproduce this, can you elaborate more clearly ?

ghost commented 8 years ago

With the continous reader, when reading from right to left. You have to enable the seamless chapter transition and the automatic deletion of picture If you're reading the last available chapter of a manga and you reach the end of it but still try to swipe for a next page, the reader is closed after asking if we want to delete it, and the chapter is reset without deleting the picture.

Don't know if it's clearer ^^

xtj-9182 commented 8 years ago

I think I understand it better now but I still can't reproduce it. I'm in continuous reader and in Right to left direction, when I go to the last chapter I get the pop up saying it's the last chapter when I check the delete images checkbox and click on close I'm back in the MangaFragment and the Images are deleted and the status of the chapter is read. I tried with a Manga and a Manhwa.

Is there any specific Manga where this is happening ?

Edit: can you try out this debug build and check if it happens in that ? redacted

ghost commented 8 years ago

The debug crashes on start ^^ Did you activate the seamless transition in the parameter ?

It happens with this manga from this server http://kissmanga.com/Manga/Yamikin-Ushijima-kun

And I noticed that if instead of pressing close I press cancel, the reader is set to the previous chapter instead of staying on the same chapter

raulhaag commented 8 years ago

got it, in last chapter (any manga) at end it say this is the lasdt chapter.... and if you select delete images it doesn't work,

raulhaag commented 8 years ago

test last commit

raulhaag commented 8 years ago

stwe @xtj-9182 about seamless transition not working like the image any problem if i mod it?

ghost commented 8 years ago

It's good now

xtj-9182 commented 8 years ago

@raulhaag no problem just go ahead. Sometimes I don't understand every part of the code yet and that was something that I couldn't figure out yet.

can you tell me what the HorizontalReader Class is doing ? Is it used in the continuous reader ?

raulhaag commented 8 years ago

@xtj-9182 in one word hierarchy, it has valid method for l2r and r2l, resolving bad hierarchy l2r extending r2l.

xtj-9182 commented 8 years ago

yeah that makes sense, at some point I was wondering why l2r would extend r2l but I didn't think too deep about that. Anyway I think this Issue can be closed now.