raulhaag / MiMangaNu

*ES - Lector de Manga online / offline, gratuito y de código abierto. *EN - Manga reader online / offline, free and open source. *FR - Lecteur de manga en ligne / hors ligne, gratuit et open source. *DE - Eine App um Manga zu lesen. Man kann damit Manga online und offline lesen. Es ist kostenlos und quelloffen. *IT - Manga lettore online / offline, gratuito e open source. *RU - В России Манга читает вас. Попробуйте MiMangaNu прямо сейчас.
277 stars 73 forks source link

Sort by Chapter Number Order Issue #520

Closed digiwombat closed 6 years ago

digiwombat commented 6 years ago

There's a minor issue with Sort by Chapter Number.

Examples are Gal Gohan and Dagashi Kashi on KissManga

Basically, the new chapters have a space in the volume number (Vol. 007 instead of Vol.007) and so the chapters appear much earlier in the list than they should.

Looks like the program sees the 007 by itself and assessment its the chapter and stops looking.

tempura-san commented 6 years ago

A workaround is to use the native order the chapters where added to the database (which is usually the order on the server).

Your guess was already good: When there are volume numbers in the title, MiMangaNu attemps to find and remove this information, as the chapter number is the only thing of relevance. The removal pattern for volumes assumed no whitespace in between the string Vol. and the number, so the volume part was not removed if a space was present (like in Vol. 007) and interfered with the chapter number parsing.

For details, see the Comparators inner class in Chapter (look for VOLUME_REMOVE_PATTERN).

Thanks for reporting! :+1:

Edit: PR #551 is already pending with the fix.