raulmur / ORB_SLAM2

Real-Time SLAM for Monocular, Stereo and RGB-D Cameras, with Loop Detection and Relocalization Capabilities
Other
9.42k stars 4.69k forks source link

include dirs thirdparty g2o #247

Open caselitz opened 7 years ago

caselitz commented 7 years ago

In the g2o CMakeLists.txt, I think a /g2o is missing. It should be

${g2o_SOURCE_DIR}/g2o/core ${g2o_SOURCE_DIR}/g2o/types ${g2o_SOURCE_DIR}/g2o/stuff

shaohuisun-zz commented 7 years ago

Not really, it works fine without this change.

caselitz commented 7 years ago

I think it works because the includes are specified relative (e.g. "../core/base_vertex.h"), so these wrong include paths are actually not used. Still they are wrong because the files do not exist at the path without /g2o since ${g2o_SOURCE_DIR}=ORB_SLAM2/Thirdparty/g2o.