raulvillares / 3sacrowd

Tic-Tac-Toe puzzle using plain javascript :video_game:
https://raulvillares.github.io/3sacrowd/index.html
35 stars 69 forks source link

Codacy issues #5

Closed raulvillares closed 6 years ago

raulvillares commented 7 years ago

There are pleeeeenty of Codacy issues. The good thing is they are easy to fix ;-)

zandermax commented 7 years ago

Since this is for first-timers, can you provide more info? Such as how to see the Codacity issues, etc.?

raulvillares commented 7 years ago

First of all @axlemax , thanks for your interest and my apologies for the poor description.

I think the easiest way the see codacy issues is to fork the project and then sign up for Codacy website with your GitHub account and add your forked repository as a new Codacy project. The downside of this approach is you only have new information when you commit and push changes to the (forked) github repository.

prabodhmeshram commented 7 years ago

All the Codacy Issues are solved ? Is this issue still relevant ?

raulvillares commented 6 years ago

No, there are still codacy issues. It's not super-important but it would be nice to have a "A" badge.

prabodhmeshram commented 6 years ago

Hey @raulvillares I did created my fork as a project in Codacy. That analyzing is taking forever and is not refreshing my changes. Hard to tell if my fixes are good or not. Did you faced something like that. Any pointer on this would be helpful.

raulvillares commented 6 years ago

Sometimes it takes up to 30 minutes. Anyway, I will like to integrate Codacy in me development envoriment (Visual Studio Code) so I can see Codacy issues without pushing in to Github. Working on it.

prabodhmeshram commented 6 years ago

That will be really great to have. Let me know if I can help in that integration part.

On Wed, Sep 20, 2017 at 3:00 PM, Raúl Villares notifications@github.com wrote:

Sometimes it takes up to 30 minutes. Anyway, I will like to integrate Codacy in me development envoriment (Visual Studio Code) so I can see Codacy issues without pushing in to Github. Working on it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/raulvillares/3sacrowd/issues/5#issuecomment-330798256, or mute the thread https://github.com/notifications/unsubscribe-auth/AGWgW6_gI4fm9hm8pr2ej41C5PuyHrr0ks5skNs1gaJpZM4NwHiQ .

-- Best Regards,

[image: --]

Prabodh Meshram [image: http://]about.me/prabodh.meshram http://about.me/prabodh.meshram?promo=email_sig

KatFrog commented 6 years ago

Is this issue still open? If so, I'd like to be assigned it.

raulvillares commented 6 years ago

Is this issue still open? If so, I'd like to be assigned it.

Go for it KatFrog. There are still 4 codacy issues. Let's see if we can get 'A' grade. Thanks!

KatFrog commented 6 years ago

Great! I'll start on it today.