search

raulvillares / 3sacrowd

Tic-Tac-Toe puzzle using plain javascript :video_game:
https://raulvillares.github.io/3sacrowd/index.html
36 stars 69 forks source link

Added a help dialog to the 'level' Element, as well as appropriate st… #65

Closed OleDakotaJoe closed 3 years ago

OleDakotaJoe commented 3 years ago

Hey, This was my first ever PR, so hopefully it checks out.

When trying to play the game at first, it was a bit hard to understand WHY what I was creating different color squares. After about 3 minutes of playing I searched for more instructions, and could not find any.

I spent about 5-10 minutes clicking random squares, when I figured out how the colors were being chosen.

I have created a simple function to create a Help Dialog box in the helpDialog.js file to separate concerns, and promote clean code.

In the Buttons file, I have added a funtion which either appends this dialog to the "level" element OR removes it if it already exists.

I have added appropriate styles to the css file, using BEM notation.

If there are any changes that need to be made, please let me know!

titivermeesch commented 3 years ago

@OleDakotaJoe PR is looking really good. Only one small thing that is bothering me, you'll see in my review.