ravachol / kew

A command-line music player
GNU General Public License v2.0
556 stars 20 forks source link

Album cover not displayed correctly in Konsole Terminal #136

Closed AmiraliToori closed 2 months ago

AmiraliToori commented 2 months ago

OS: Kubuntu 22.04.3 Terminal Emulator: Konsole File format: mp3 The issue is the same for other file formats.

Using Image Cover:

image image

ravachol commented 2 months ago

Hi, can you tell us a bit more about the problem? Do you know if this worked correctly for you in previous versions? I'm not able to reproduce it.

AmiraliToori commented 2 months ago

Since version 2.4.4, when I started using the kew, this problem has remained; recently I updated to the latest version which is 2.5.0, but nothing changed and the cover album of all my songs displayed the way the uploaded screenshot shows. I checked the dependencies, and all of them are updated.

ravachol commented 2 months ago

ok, we use a program called Chafa to display the images. If the images aren't displaying correctly it likely can either be a terminal that doesn't support images well, or something with Chafa, maybe the wrong version.

what does it say if you type this in the console: chafa --version

AmiraliToori commented 2 months ago

Output:

Chafa version 1.8.0

Features: mmx sse4.1 popcnt
Applying: mmx sse4.1 popcnt

Copyright (C) 2018-2021 Hans Petter Jansson et al.
Incl. libnsgif copyright (C) 2004 Richard Wilson, copyright (C) 2008 Sean Fox

This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
ravachol commented 2 months ago

Thanks, I don't know if there's a problem with later versions of chafa on kubuntu, there might be, but that is an old version of Chafa, and could be the reason why the graphics are wrong. Chafa is at version 1.14.1.

AmiraliToori commented 2 months ago

Install Chafa version 1.14.1, Nothing changes. Tried other terminal emulators such as GNOME-terminal, Xterm, and Yakuake, but The problem is still present. I notice that when I decrease the size of the font of the terminal, the album cover becomes clearer, but not like the original one.

Output of chafa --version:

Chafa version 1.14.1

Loaders:  GIF JPEG PNG QOI SVG TIFF WebP XWD
Features: mmx sse4.1 popcnt avx2
Applying: mmx sse4.1 popcnt avx2

Copyright (C) 2018-2023 Hans Petter Jansson et al.
Incl. libnsgif copyright (C) 2004 Richard Wilson, copyright (C) 2008 Sean Fox
Incl. LodePNG copyright (C) 2005-2018 Lode Vandevenne
Incl. QOI decoder copyright (C) 2021 Dominic Szablewski

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Album cover when the font size is set to 4:

image

ravachol commented 2 months ago

Ok, that's good to know about the font size. That last image looks a lot better. The image quality is never going to be 100% as good as in an image viewer, but it can look better than that in Konsole.

I don't think there's anything I can do about this to be honest, it's probably an issue/limitation with Chafa somehow, or a setting somewhere. If you want you could ask them and refer to this issue: https://github.com/hpjansson/chafa/

ravachol commented 2 months ago

Closing this. Reason for the issue was a too old version of Konsole.