search

ravachol / kew

A command-line music player
GNU General Public License v2.0
567 stars 21 forks source link

Libnotify creates new notifications instead of updating the same one #142

Closed kazemaksOG closed 2 months ago

kazemaksOG commented 2 months ago

Current implementations just sends out a new notification every time a music switch happens. This can clutter the notification space if browsing through music. This is mostly due to the fact that libnotify library is not directly used, and notify-send is issued through execv.

Current: image

I locally already changed this to only update the current notification, but i don't think i have the rights to make a pull requests. Only downside of this is that it did require me to add another library to the project, which may not be desirable.

Changed: image

ravachol commented 2 months ago

I think anyone has the right to make a pull request. Previously there were requests for not adding that dependency, that's why we did it the way we did. I think you can go ahead and make the pull request, I will have a look at it. It's the proper way to do things, and doing it the way we are doing has already caused other problems.

ravachol commented 2 months ago

Ok, this has been merged to develop branch, and also I've made it an optional thing so that it is used only if you have libnotify installed. Thank you @kazemaksOG.

kazemaksOG commented 2 months ago

Thank you for maintaining this amazing piece of software @ravachol c: