search

ravachol / kew

A command-line music player
GNU General Public License v2.0
567 stars 21 forks source link

[bug] cover not displaying anymore #145

Closed werdahias closed 1 month ago

werdahias commented 1 month ago

With 2.6 the cover art stopped to display for me. Tested both in blackbox-terminal and foot.

ravachol commented 1 month ago

Thanks for letting me know, I will investigate..

ravachol commented 1 month ago

I can not get covers to work on blackbox-terminal in either new or old versions. Tested 2.4.2 and 2.6.

In foot I can make it work in both old and new kew versions.

One thing that it probably isn't but could be is that you pressed c at some point which toggles covers on and off. This setting is automatically saved. And maybe shouldn't be there at all because it's easy to press c at some point without thinking about it and it could lead to a lot of confusion. It was implemented early for when there was only ascii covers available, and maybe not everbody liked them.

If it's not that it gets tougher as I can't reproduce it. There's nothing I can remember that I've changed regarding that code either.

ravachol commented 1 month ago

black box does not support sixels (graphics).

werdahias commented 1 month ago

ah this was indeed caused by me having pressed c, sorry for the noise

ravachol commented 1 month ago

Yeah, but thanks anyway because now I am going to remove that option. :)

It shouldn't be there and you can't be the only one that that has happened to.