ravachol / kew

A command-line music player
GNU General Public License v2.0
567 stars 21 forks source link

[BUG] After most recent update arrow keys have stopped working as keybindings, and changing keybindings in kewrc config file does not seem to work. #98

Closed Jaoheah closed 9 months ago

Jaoheah commented 9 months ago

After the latest update the arrow keys seem to not be working as keybindings. I have the kew-git package from the AUR installed. Its version is v1.9.r0.ge89f029-1

This issue with the arrow keys not working caused me to use the alt keybindings for scrolling through playlists which is J and K, as I don't use them I didn't realize that J is used for moving downwards while K is for moving upwards, so I tried to change it to how I preferred it which would be J for scrolling upwards and K for scrolling downwards in the Kew config file, and this led me to realize that it does not seem to work.

When I go to change

scrollUpAlt=k
scrollDownAlt=j

to

scrollUpAlt=j
scrollDownAlt=k

it does not work, after I save the file and quit and relaunch Kew, the file gets reset to how it was before I changed and saved the file. Kew seems to overwrite it.

This is the contents of my kewrc file (it seems to be stuck like this, no change that I do lasts):

path=/home/jaoheah/Music
coverEnabled=1
coverAnsi=1
visualizerEnabled=1
visualizerHeight=8
useProfileColors=0
volumeUp=+
volumeDown=-
previousTrackAlt=h
nextTrackAlt=l
scrollUpAlt=k
scrollDownAlt=j
switchNumberedSong=
togglePause=p
toggleColorsDerivedFrom=i
toggleVisualizer=v
toggleCovers=c
toggleAscii=b
toggleRepeat=r
toggleShuffle=s
seekBackward=a
seekForward=d
savePlaylist=x
addToMainPlaylist=.
quit=q
# For special keys use terminal codes OS, for F4 for instance. This can depend on the terminal.

this is the results of when I right click on the kewrc config file, and click "Copy Location": /home/jaoheah/.config/kewrc

The config file seems to be in the right place.

ravachol commented 9 months ago

the file gets written every time you quit so if you have the program running and edit the file, it just overwrites your changes. I should do something about that. :o A bit hard to understand. But this is to write the default file in case you lose the file somehow, or to get key binding options back in case you've removed them.

The other issue with the arrows not working is strange, because I haven't changed anything regarding that.

I'm not a vim user, but I think k up and j down is the correct vim way.

ravachol commented 9 months ago

have you maybe switched terminal?

Jaoheah commented 9 months ago

the file gets written every time you quit so if you have the program running and edit the file, it just overwrites your changes. I should do something about that. :o A bit hard to understand. But this is to write the default file in case you lose the file somehow, or to get key binding options back in case you've removed them.

I just managed to figure that out on my own, I was about to edit the issue regarding that before I realized you responded.

Maybe it should be put in the config file that the program needs to be closed first?

The other issue with the arrows not working is strange, because I haven't changed anything regarding that.

I am not sure why this is happening.

I'm not a vim user, but I think k up and j down is the correct vim way.

That seems to be the correct way, I looked it up online, I am not a vim user either. I knew the vim keybindings was comprised of hjkl but I always assumed that J was up, and that's how I would prefer it, so that's why I mentioned me changing it to that.

have you maybe switched terminal?

No, I have always used Konsole, the default KDE terminal.

Jaoheah commented 9 months ago

Wait all of a sudden the arrow keys are working again. I am completely at a loss.

ravachol commented 9 months ago

Maybe it should be put in the config file that the program needs to be closed first?

Definitely. That's a good solution. I've added it and it will be in the next version.

Jaoheah commented 9 months ago

Though the arrow keys working only seems to have happened after I successfully changed the keybindings in the config, it wasn't working whatsoever before that.

Jaoheah commented 9 months ago

Maybe it should be put in the config file that the program needs to be closed first?

Definitely. That's a good solution. I've added it and it will be in the next version.

I'll make a proper suggestion for it, as I have some other ideas for how the config is formatted