search

ravahn / FFXIV_ACT_Plugin

FFXIV Plugin for Advanced Combat Tracker
716 stars 59 forks source link

Improve "Hide Chat Log" for privacy #264

Open quisquous opened 3 years ago

quisquous commented 3 years ago

A lot of people accidentally click "hide chat log" for privacy which (I think) cuts out all 00 game log messages. This causes a lot of support issues with triggers.

A blocklist might be hard here because there's quite a few ways that chat happens. However, maybe it'd be easy to have an allowlist to allow non-chat game log messages to still be written? The full list of things I personally would find useful is:

ravahn commented 3 years ago

I'm thinking about a couple of different solutions here, but the quickest one we discussed in Discord is to just expose the configuration setting for hiding chatlog text, so I'll add that first.

Lets see how that goes for now, and reevaluate for 6.0 whether to do more.

ravahn commented 2 years ago

@quisquous I did not add more for this feature in 6.0, but now the System message IDs are saved in the log file, which can be used for a subset of what you listed. fishing stuff, one npc message, and zone sealing should be included, but I am not sure about NPC text.

quisquous commented 2 years ago

Maybe! I have not had enough time to dig into these to understand what the fields are here and if I can make a 1:1 conversion from one to the other or if there's anything missing. I'll try to take a look in the next two weeks pre-savage and see if I can better understand these lines and follow back up here. Thanks for the update.

JaneSmith commented 2 years ago

I'm very confused about what this setting even does. Apologies if I shouldn't be asking this here, but could anyone explain what it does? I do care about my privacy. Should I be enabling this? What exactly does it protect me from? I find it really unclear, but it doesn't seem to be explained anywhere. I did a search online and the only two things I could find talking about it, were this issue, and someone saying Cactbot needs it turned off (without explaining why). Thanks.

valarnin commented 2 years ago

By default, when the FFXIV ACT Plugin generates log files, it includes the chat log (e.g. player messages, system messages, NPC RP text from cutscenes or mid-encounter dialog).

Enabling the Hide Chat Log option will cause the plugin to no longer process these lines and write them to the log file. This can be useful if you want to send your log files to another person, but don't want them to be able to see your /tell's, /fc chat, etc. This isn't applicable to most users, since most users are just using the plugin to display DPS locally or to upload to FFLogs, the latter of which strips the chat log lines from the file before sending it IIRC.

Certain triggers and timeline syncs in Cactbot rely on the chat log lines, so checking the box to hide them can cause problems. A list of examples that show up via a quick search include:

  1. Eureka overlay functionality
  2. Fisher overlay functionality
  3. PullCounter overlay functionality
  4. Radar overlay functionality
  5. Raidboss, a ton of miscellaneous things, including:
    • The Ready Check trigger
    • Various components of the test triggers involved in Summerford Farms
    • Haukke Manor final boss trigger
    • Coils 1 and Coils 8 triggers
    • Dun Scaith and Weeping City triggers
    • A11S trigger
    • Bardam's Mettle trigger
    • Various Eureka triggers
    • UCOB triggers
    • Copied Factory triggers
    • various other triggers I'm not going to bother listing them all
    • A ton of syncs for timelines across almost every zone
JaneSmith commented 2 years ago

Thank you so much for that detailed answer! Super helpful.

quisquous commented 1 year ago

Another thing that would help here is if the ffxiv plugin could expose these settings so they could be included in the "copy tech support info to clipboard" OverlayPlugin button so that it's clear when a setting like this is turned on.