search

ravanrijn / styx

Styx the open source Cloud Foundry console
MIT License
26 stars 10 forks source link

Don't log usernames and passwords #1

Closed mstine closed 11 years ago

mstine commented 11 years ago

While trying to troubleshoot an installation of styx, I noticed the following in the debug output:

17:19:06.605 [http-bio-61027-exec-5] DEBUG o.s.web.client.RestTemplate - Writing [{grant_type=[password], username=[admin], password=[--REDACTED--]}] as "application/x-www-form-urlencoded;charset=utf-8" using [org.springframework.http.converter.support.AllEncompassingFormHttpMessageConverter@37d53baa]

ravanrijn commented 11 years ago

Thanks for pointing that out. I have implemented log masking to prevent passwords from being logged.

mstine commented 11 years ago

Nice! Thanks. :-)

On Fri, Aug 9, 2013 at 2:11 AM, ravanrijn notifications@github.com wrote:

Thanks for pointing that out. I have implemented log masking to prevent passwords from being logged.

— Reply to this email directly or view it on GitHubhttps://github.com/ravanrijn/styx/issues/1#issuecomment-22378680 .

Matt Stine Deep South Software: Training, Consulting, Coaching http://www.deepsouthsoftware.com matt.stine@gmail.com