search

raveberry / raveberry

A multi-user music server with a focus on participation
GNU Lesser General Public License v3.0
716 stars 44 forks source link

Feature Request: Ability to make local results appear first in search vs online results #72

Open tiny-e opened 4 years ago

tiny-e commented 4 years ago

Potential bandwidth savings...

raveberry commented 4 years ago

Do you want local songs to appear even before the online suggestions?

I don't want to put the local files on top by default, as some queries lead to a lot of local songs (searching for the artist for example). Then, the other platforms could not even be seen in the suggestions window.

I could imagine some sort of list in the settings that indicates the order in which suggestions are shown. You could then drag the items around to customize the order in which they appear on the main page.

tiny-e commented 4 years ago

Correct -- or at least the option to have local files show up before downloading anything. Currently I'm only testing youtube as I don't have a spotify premium account. Youtube produces a lot of garbage search results that wind up moving the local files off of the list (or way down by the bottom). In a mobile environment, where data costs money, it would be preferable to use local files vs pulling them down from the internet.

![image](https://user-images.githubusercontent.com/2148511/88303599-d52b4980-cccc-11ea-9d41-723eb01684fc.png

Like in this example, I'm looking for the song "Patience", which I know exists in my library. But it places a bunch of youtube stuff ahead of it. --maybe an idea would be to have user-defined keywords that could be added to the youtube search?

image

raveberry commented 4 years ago

This looks like the number of online suggestions for Youtube is really high. Did you increase it on purpose? With the default value of two it would not occupy the whole suggestion window.

I have another suggestion. Instead of introducing a rather complicated configuration to reorder the suggestions, I could add a checkbox to activate "offline mode". Raveberry already behaves differently if it can not connect to the internet. It will not show online suggestions and only lists files that are available without internet. Currently, this mode is only triggered if there is actually no internet, but I could easily make it an option. Then you would be safe in a mobile environment and could enable all features back at home.

tiny-e commented 4 years ago

So -- I had cranked the value up high (40) to see what it would find as it was showing irrelevant results with a low setting. I've also re-set it to 3 and rebooted, but it's still showing me way more than 3 suggestions. Would it be difficult to integrate a keywords list (user definable) into the search? The keywords would be appended to the user-entered search term. So if, for example, I typed "Song Name" in the search bar, it would actually search for "Song Name Vevo" (or whatever words I had in my keywords field)?

On Thu, Jul 23, 2020 at 12:56 PM Raveberry notifications@github.com wrote:

This looks like the number of online suggestions for Youtube is really high. Did you increase it on purpose? With the default value of two it would not occupy the whole suggestion window.

I have another suggestion. Instead of introducing a rather complicated configuration to reorder the suggestions, I could add a checkbox to activate "offline mode". Raveberry already behaves differently if it can not connect to the internet. It will not show online suggestions and only lists files that are available without internet. Currently, this mode is only triggered if there is actually no internet, but I could easily make it an option. Then you would be safe in a mobile environment and could enable all features back at home.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/raveberry/raveberry/issues/72#issuecomment-663147770, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQMRH24X4ZNIOKC4AK34NLR5B2TLANCNFSM4PE4VGTQ .

raveberry commented 4 years ago

Changing the number of online suggestions should take effect immediately. Did you change "Number of suggestions" which controls the total number of suggestions shown, or "Number of online suggestions" in the Youtube section, which controls the number of online suggestions taken from Youtube?

Adding a "Additional Keywords" section should be possible, but it's a little more invasive. Currently https://github.com/raveberry/raveberry/pull/73 is open, which adds the option to filter with specified keywords. During search, songs containing these keywords are disregarded and not enqueued.

The "Additional Keywords" thing would work similarly, modifying the search process as well. When I come around to merging the pull request I could add your suggested option as well.

tiny-e commented 4 years ago

I did change the wrong item initially...

tiny-e commented 4 years ago

I've added spotify premium for testing --which is cool, and appears to work nicely. I would be really beneficial to have local results at the top to keep users from pulverizing my data plan :). They will click on the first thing they see (that meets their query).

raveberry commented 4 years ago

Adding a reorder option is some work, but I see your point. Until something like that exists, you could set the number of Spotify online suggestions to zero. This way, they won't appear in the suggestions window. Tapping the magnifying glass will still search Spotify, so you don't lose that ability. Spotify suggestions that appear below the online suggestions have already been played at least once. From my understanding, these are cached by the mopidy Spotify plugin. An Internet connection is still required to fetch the decryption key (I guess), but no large files should be downloaded. If this is not the case, you can still set the number of Spotify (offline) suggestions to zero as well.

tiny-e commented 4 years ago

Interesting -- I turned the spotify results down to 0 and then did a search for an artist by clicking the magnifying glass -- it started playing a random song by that artist. No ability to choose. Probably the same idea as my 'enter' key post..

tiny-e commented 4 years ago

it also seems that if there are no songs in the queue, the spotify plugin goes ahead and adds some one its own?

raveberry commented 4 years ago

Maybe I need to communicate the purpose of the magnifying glass better. It is not meant to be a search that results in a list of options. It is meant to be a search for the query that was given, resulting in a (or hopefully the intended) song. Turning the number of Spotify results to 0 does remove all Spotify suggestions, this is the intended behavior. It was a suggestion for you to prevent users from tapping the first suggestions they get, incentivizing them to use the local songs.

As for the auto-add: This is not Spotify-specific behavior, you might have enabled autoplay, indicated by the circle-in-a-triangle button in the last row of the playback controls.

raveberry commented 4 years ago

Adding a "Additional Keywords" section should be possible, but it's a little more invasive. Currently #73 is open, which adds the option to filter with specified keywords. During search, songs containing these keywords are disregarded and not enqueued.

The "Additional Keywords" thing would work similarly, modifying the search process as well. When I come around to merging the pull request I could add your suggested option as well.

This is now an option with 0.7.3.