ravenac95 / sudolikeaboss

Get 1password access from iterm2
http://sudolikeaboss.com
MIT License
1.51k stars 50 forks source link

1Password 5: "Cannot Fill Item in Web Browser" #1

Closed stayradiated closed 10 years ago

stayradiated commented 10 years ago

OS X 10.10 and 1Password 5.0.1.

Running sudolikeaboss displays the 1Password Mini window, but when I select an item it displays this error message:

Cannot Fill Item in Web Browser Web Browser is connected but its code signature could not be verified. Filling and other features are disabled until this configuration issue is resolved.

At first I thought maybe I could disable "Verify browser code signature" in the 1Password Preferences. But it didn't make any difference.

image

ravenac95 commented 10 years ago

Awesome catch. I am gonna update my system to 10.10 tonight. I will look into the issue asap!

ghazlewood commented 10 years ago

I got the same error in 10.9.5 and 1Password 4.4.3 if I don't uncheck "Verify browser code signature"

mhite commented 10 years ago

I also experience this error with Yosemite and 4.4.2. Like the previous commenter, you have to disable browser code signature verification to get it to work right.

pencil commented 10 years ago

Please take a look at the screenshot. "Verify browser code signature" is unchecked.

phuibonhoa commented 10 years ago

It also doesn't work for me even with Verify browser code signature is unchecked.

deivuh commented 10 years ago

Can confirm, not working with the signature verification option unchecked for me either.

ravenac95 commented 10 years ago

Hey guys, I can also reproduce on my newly upgraded box. I believe the problem may actually lie with 1password's implementation of it's Verify browser code signature option. That said, I will be looking in to work arounds once I'm out of work today.

I have a hunch that it could be something to do with Apple's Gatekeeper, so potentially coming up with some kind of signed bundle would work. However, I've never done that so any help in this matter would rock. I too want this working as I use sudolikeaboss everyday.

ravenac95 commented 10 years ago

There's definitely a problem with 1password itself in this arena. See: https://discussions.agilebits.com/discussion/30025/osx-10-10-1password5-chromium#latest. I do have an idea for a workaround but it'll take a little while to complete it. I'll keep everyone posted.

ravenac95 commented 10 years ago

I have a super hacky fix that's working on my box at home. Anyone willing to be a guinea pig and help me test it out?

alex-kovshovik commented 10 years ago

Me! Yes, please! I'll test it for you!

ravenac95 commented 10 years ago

@aspushkinus Awesome. I'll send it to you once I'm off work! I haven't automated the installation yet so I hope you're fine with doing some legwork.

alex-kovshovik commented 10 years ago

Not a problem, I can get my hands dirty editing scripts, bash, etc.

ravenac95 commented 10 years ago

If you'd like to see the changes. It's on this branch:

https://github.com/ravenac95/sudolikeaboss/tree/1-fix-cannot-fill-item

I'm still cleaning it up.

alex-kovshovik commented 10 years ago

@ravenac95 your "beta" version works like a charm! Thank you for this hacky fix! :+1:

ravenac95 commented 10 years ago

@aspushkinus Wonderful! I'm going to clean it up. If anyone else on this thread can test it that would be great!

ravenac95 commented 10 years ago

There's now a fix for this! I've uploaded the fix to homebrew. You'll need to follow these instructions to get the fix!

  1. Uninstall/reinstall sudolikeaboss:

    $ brew uninstall sudolikeaboss
    $ brew update
    $ brew install sudolikeaboss
  2. Install the workaround:

    $ brew install sudolikeaboss-workaround
    $ sudolikeaboss-setup-workaround
  3. You now have the shim and the workaround server. Next, you need to add the Coprocess to iTerm2. Use the gif below as a guide on how to configure iterm2 for the Coprocess except instead of using:

    /usr/local/bin/sudolikeaboss

    use this:

    SUDOLIKEABOSS_WEBSOCKET_URI="ws://127.0.0.1:16263/slab" /usr/local/bin/sudolikeaboss

In order for the workaround to work, Chrome must be running. If this isn't satisfactory, AgileBits will come out with a fix in the future. I just don't know when that will happen.

stayradiated commented 10 years ago

Thank you. I can confirm that this fix works on 10.10.

Also, if anyone is having issues after installing the workaround, try restarting your computer and seeing if that fixes it.

ravenac95 commented 10 years ago

@stayradiated I found an additional bug with the workaround. If you upgrade the package through brew the latest will likely fix the issue of having to restart.

BrianGilbert commented 9 years ago

It seesm that agilebits have fixed the issue that was causing this problem now, can we get an update please? https://discussions.agilebits.com/discussion/comment/159692/#Comment_159692

ravenac95 commented 9 years ago

@BrianGilbert Good catch. I didn't see the response till you sent this message. The fix isn't out just yet. It's just in a beta build so I'm going not going to remove the part about the workaround from the README, I'll add a section about the latest beta build, though. Luckily, once they release the fix, no one should need to do anything but follow the README's installation instructions except for the part about the workaround.

BrianGilbert commented 9 years ago

I'm using the beta versions of 1pass so would be happy to test.

BrianGilbert commented 9 years ago

@ravenac95 was that Agilebits fix only supposed to make it work when you unselect "Verify code browser signature"?

ravenac95 commented 9 years ago

@BrianGilbert I've been testing with the 1password beta and it works great. If you'd like to try it out just install sudolikeaboss as you normally would do not install the workaround. If you did make sure the coprocess installed on iterm2 is simply: /usr/local/bin/sudolikeaboss. Then, disable the "Verify Code Browser Signature".

So if it wasn't clear, the answer to your second question is yes.

On a related note, I've emailed Agilebits to see if they could put sudolikeaboss's signature into 1password so that you DO NOT have to disable this setting. I haven't yet received a response.

yacitus commented 9 years ago

Nothing happens when I try my keyboard shortcut in iTerm2.

Not surprisingly, when I run SUDOLIKEABOSS_WEBSOCKET_URI="ws://127.0.0.1:16263/slab" /usr/local/bin/sudoleaboss at the command-line, it doesn't return. I have installed the sudolikeaboss-workaround, and ran sudolikeaboss-setup-workaround, and restarted Chrome.

I noticed that after I run sudolikeaboss-setup-workaround, the 1Password extension is disabled in Chrome and Chrome reports: "This extension may have been corrupted." If I click on "Repair" it is re-enabled, but SUDOLIKEABOSS_WEBSOCKET_URI="ws://127.0.0.1:16263/slab" /usr/local/bin/sudoleaboss still hangs.

Note running /usr/local/bin/sudolikeaboss brings up 1Password, but then I get the "Cannot Fill Item in Web Browser" dialog.

yacitus commented 9 years ago

/usr/local/bin/sudolikeaboss works great (at the command-line and as the iTerm2 coprocess) with 1Password 5 Version 5.1.BETA-34 (510034), once I disabled "Verify browser code signature" in the Advanced tab of the 1Password preferences.

ravenac95 commented 9 years ago

@yacitus I think chrome has been making updates that may render the workaround non-functional. I would highly suggest that people now just install the beta of 1password 5.1 I've been using it to great success on my end.

alex-kovshovik commented 9 years ago

1password 5.1 is out of beta and sudolikeaboss works like boss now - without workaround.

BTW, I'm not a big fan of installation instructions as a gif. Going to create a pull request for list-based installation instructions.

a5e commented 9 years ago

I tried first without the workaround and I did have the "Cannot Fill Item in Web Browser" error. Tried the workaround and still the same error. Then I saw that it was not needed anymore since I have 1P 5.1. I ran:

brew uninstall sudolikeaboss-workaround
brew uninstall sudolikeaboss

I restarted

brew install sudolikeaboss

Still got the same issue, any idea what I'm missing ?

alex-kovshovik commented 9 years ago

Even though the workaround is no longer necessary, you need to still uncheck the "Verify browser code signature" checkbox in 1Password 5.1 settings:

preferences

a5e commented 9 years ago

@aspushkinus thanks, I thought the workaround was a way to keep it checked, this paragraph is not very clear in the README, will do a PR.

kgadek commented 8 years ago

Works for me without workaround.

$ sudolikeaboss --version
sudolikeaboss version 0.2.0

$ sw_vers -productVersion
10.11.1
1Password 5
Version 5.4.1 (541003)
rodneyo commented 8 years ago

Awesome! iterm2 plugin. Thank you !!!