Another IdentityServer4.RavenDB

ravendb / IdentityServer4.Contrib.RavenDB

MIT License

9 stars 3 forks source link

Another IdentityServer4.RavenDB #2

Closed TheKeyblader closed 3 years ago

TheKeyblader commented 4 years ago

Hello.

I also created recently an implementation. Hopefully, I found your repository before I upload it to nuget.org. I hope the first release will go out soon

So I have some ideas to propose :

AllowedAccessTokenSigningAlgorithms can be a list of string like the original entity. This allows deleting AllowedSigningAlgorithmsConverter.
For token cleanup, using document expiration will be a better integration than a cleaning thread, I think.

DejanMilicic commented 4 years ago

@TheKeyblader Thank you for your suggestions. Are these two implemented in your repository?

I will inspect what you have done, compare it with my implementation, and see what could be merged into code I wrote if you agree?

TheKeyblader commented 4 years ago

Yes, I implemented these two. Take everything you need.